From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38524 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzA2g-0000Wk-NK for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:50:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzA2f-00032d-7Q for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:50:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzA2e-00032S-VF for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:50:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EFohJT012815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Mar 2011 11:50:44 -0400 Message-ID: <4D7E393D.3030408@redhat.com> Date: Mon, 14 Mar 2011 16:50:21 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/7] introduce libcacard/vscard_common.h References: <1298460024-23591-1-git-send-email-alevy@redhat.com> <1298460024-23591-3-git-send-email-alevy@redhat.com> <4D7E1FAF.8020605@redhat.com> <20110314145253.GG31372@playa.tlv.redhat.com> In-Reply-To: <20110314145253.GG31372@playa.tlv.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/14/11 15:52, Alon Levy wrote: >> [snip] >>> > > +/* VSCMsgInit Client <-> Host >>> > > + * Client sends it on connection, with its own capabilities. >>> > > + * Host replies with VSCMsgInit filling in its capabilities. >>> > > + * >>> > > + * It is not meant to be used for negotiation, i.e. sending more then >>> > > + * once from any side, but could be used for that in the future. >>> > > + * */ >> > >> > Looks like some automatic mangling of comments - happens in more than >> > one place. > What, the repeated "capabilities" word at the end of two consecutive lines? > that's on purpose. Nope the * * * * */ looks odd. Jes