From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39025 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzA3U-0000yE-DO for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzA3S-0003H5-6l for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:51:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzA3R-0003Gx-Rz for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:51:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EFpW89000641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Mar 2011 11:51:33 -0400 Message-ID: <4D7E396D.7050000@redhat.com> Date: Mon, 14 Mar 2011 16:51:09 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/7] ccid: add passthru card device References: <1298460024-23591-1-git-send-email-alevy@redhat.com> <1298460024-23591-4-git-send-email-alevy@redhat.com> <4D7E2054.2080003@redhat.com> <20110314145333.GH31372@playa.tlv.redhat.com> In-Reply-To: <20110314145333.GH31372@playa.tlv.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/14/11 15:53, Alon Levy wrote: > On Mon, Mar 14, 2011 at 03:04:04PM +0100, Jes Sorensen wrote: >> On 02/23/11 12:20, Alon Levy wrote: >>> The passthru ccid card is a device sitting on the usb-ccid bus and >>> using a chardevice to communicate with a remote device using the >>> VSCard protocol defined in libcacard/vscard_common.h >>> >>> Usage docs available in following patch in docs/ccid.txt >>> >>> Signed-off-by: Alon Levy >>> >> >> Except for the usual formatting bits, this one looks fine to me. > > What exactly? The comments formatting as I mentioned in previous patches. Jes