From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36027 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzDhf-0008Fy-JH
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:45:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1PzDhc-000897-6s
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:45:17 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:41740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1PzDhc-000892-3L
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:45:16 -0400
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2EJOMbg028303
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 15:24:22 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 4218638C803B
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 15:45:12 -0400 (EDT)
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p2EJjFcH325102
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 15:45:15 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p2EJjEe3002095
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 16:45:14 -0300
Message-ID: <4D7E7049.10304@us.ibm.com>
Date: Mon, 14 Mar 2011 14:45:13 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format
	an error
References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com>
	<1299877249-13433-3-git-send-email-aliguori@us.ibm.com>
	<4D7A8F56.2080703@us.ibm.com> <20110314161728.36c3ca7e@doriath>
	<4D7E6C22.8010102@codemonkey.ws> <20110314163747.77392d06@doriath>
In-Reply-To: <20110314163747.77392d06@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Michael D Roth <mdroth@us.ibm.com>, Markus Armbruster <armbru@redhat.com>

On 03/14/2011 02:37 PM, Luiz Capitulino wrote:
>
> qerror_abort() only exists for debugging purposes. I won't say its perfect,
> but it's better than nothing and has already saved some time when writing
> new errors.
>
> I'm fine dropping it as long as there's a better replacement, which is
> not the case here. There's even a hunk that replaces qerror_abort() for
> a plain abort().

Yes, that's the replacement.

Regards,

Anthony Liguori