From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53332 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzEP8-0000Bt-OZ for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:30:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzEP7-0008Ff-K5 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:30:14 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:53245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzEP7-0008FS-Gd for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:30:13 -0400 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2EKApEY014940 for ; Mon, 14 Mar 2011 16:10:51 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 2F2B16E803C for ; Mon, 14 Mar 2011 16:30:12 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2EKUBZF316838 for ; Mon, 14 Mar 2011 16:30:11 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2EKUBtg007321 for ; Mon, 14 Mar 2011 16:30:11 -0400 Message-ID: <4D7E7AD2.8020806@us.ibm.com> Date: Mon, 14 Mar 2011 15:30:10 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com> <1299877249-13433-5-git-send-email-aliguori@us.ibm.com> <20110314161853.0b9f5921@doriath> <4D7E6B75.8080801@us.ibm.com> <20110314163005.624a2db3@doriath> In-Reply-To: <20110314163005.624a2db3@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , qemu-devel@nongnu.org, Michael D Roth , Markus Armbruster On 03/14/2011 02:30 PM, Luiz Capitulino wrote: >> libqmp >> >> It's very nice to have client code that convert QMP errors to human >> readable strings. > Ok. I'm not sure if I would bother doing this kind of change in this > series (as it's mainly re-working internal stuff) but, this has to be > explained in the log message then. I'll clarify in the log. There's a lot of code in this series to merge. I'll do my best to make review as easy as possible but I need a bit of flexibility in terms of merging some infrastructure bits first followed by the bits that use it. Everything is already written. I just didn't want to bombard the list with a 200 patch series. Regards, Anthony Liguori