From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56783 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzEaQ-0004v1-WE for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzEaP-0001zt-J3 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:41:54 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:58974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzEaP-0001zk-GX for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:41:53 -0400 Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2EKNKMD005285 for ; Mon, 14 Mar 2011 16:23:20 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id E0D9F38C8038 for ; Mon, 14 Mar 2011 16:41:48 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2EKfpl7264568 for ; Mon, 14 Mar 2011 16:41:52 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2EKfpvk031953 for ; Mon, 14 Mar 2011 16:41:51 -0400 Message-ID: <4D7E7D8D.8040300@us.ibm.com> Date: Mon, 14 Mar 2011 15:41:49 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com> <1299877249-13433-3-git-send-email-aliguori@us.ibm.com> <4D7A8F56.2080703@us.ibm.com> <20110314161728.36c3ca7e@doriath> <4D7E6C22.8010102@codemonkey.ws> <20110314163747.77392d06@doriath> <4D7E7049.10304@us.ibm.com> <20110314172207.15587e00@doriath> In-Reply-To: <20110314172207.15587e00@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , qemu-devel@nongnu.org, Michael D Roth , Markus Armbruster On 03/14/2011 03:22 PM, Luiz Capitulino wrote: > On Mon, 14 Mar 2011 14:45:13 -0500 > Anthony Liguori wrote: > >> On 03/14/2011 02:37 PM, Luiz Capitulino wrote: >>> qerror_abort() only exists for debugging purposes. I won't say its perfect, >>> but it's better than nothing and has already saved some time when writing >>> new errors. >>> >>> I'm fine dropping it as long as there's a better replacement, which is >>> not the case here. There's even a hunk that replaces qerror_abort() for >>> a plain abort(). >> Yes, that's the replacement. > It's not a good one: it makes the current code a bit worse and we don't know > how and when the error classes are going to be replaced. Yes, we do, before 0.15.0. > Maybe a better merge plan would be to work on errors first. Completely drop > qerror according to qapi needs, and then put the rest of the stuff on top. Can't be done until we introduce new QMP commands to get rid of the old HMP commands because there are HMP commands without equivalents that make use of qerror_report(). There are just a handful of these left in my QAPI branch so once I can start adding these QMP commands, they'll be gone quickly. I don't want to introduce a bunch of new QMP commands without this stuff getting merged upstream first though. Regards, Anthony Liguori