Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/14/2011 03:48 PM, Luiz Capitulino wrote:
> On Mon, 14 Mar 2011 15:41:49 -0500
> Anthony Liguori<aliguori@us.ibm.com>  wrote:
>
>> On 03/14/2011 03:22 PM, Luiz Capitulino wrote:
>>> On Mon, 14 Mar 2011 14:45:13 -0500
>>> Anthony Liguori<aliguori@us.ibm.com>   wrote:
>>>
>>>> On 03/14/2011 02:37 PM, Luiz Capitulino wrote:
>>>>> qerror_abort() only exists for debugging purposes. I won't say its perfect,
>>>>> but it's better than nothing and has already saved some time when writing
>>>>> new errors.
>>>>>
>>>>> I'm fine dropping it as long as there's a better replacement, which is
>>>>> not the case here. There's even a hunk that replaces qerror_abort() for
>>>>> a plain abort().
>>>> Yes, that's the replacement.
>>> It's not a good one: it makes the current code a bit worse and we don't know
>>> how and when the error classes are going to be replaced.
>> Yes, we do, before 0.15.0.
> Very optimistic :) I don't doubt you can post patches quickly, but we're
> likely going to have fun discussions, respins, tests etc. And all the QAPI
> stuff in parallel.

Let's have those discussions then because that's what's important.

I split this out because I didn't want to have a 40 patch series so I 
tried to split into two logical series.

But the goal is here QAPI.  That's what's important to get merged.  I'm 
not terribly interested in merging these changes until we're ready to 
merge the first round of QAPI.

It's a big change, and it's optimistic, but that's what makes it worth 
trying to do.

Regards,

Anthony Liguori