From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46950 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzEvz-0001sP-29 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzEvx-0006D7-Ub for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:04:11 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:34999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzEvx-0006D3-Pn for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:04:09 -0400 Received: by iym7 with SMTP id 7so6253673iym.4 for ; Mon, 14 Mar 2011 14:04:08 -0700 (PDT) Message-ID: <4D7E82B6.2090809@codemonkey.ws> Date: Mon, 14 Mar 2011 16:03:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com> <1299877249-13433-3-git-send-email-aliguori@us.ibm.com> <4D7A8F56.2080703@us.ibm.com> <20110314161728.36c3ca7e@doriath> <4D7E6C22.8010102@codemonkey.ws> <20110314163747.77392d06@doriath> <4D7E7049.10304@us.ibm.com> <20110314172207.15587e00@doriath> <4D7E7D8D.8040300@us.ibm.com> <20110314174826.6c9a90f3@doriath> In-Reply-To: <20110314174826.6c9a90f3@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, Michael Roth , Markus Armbruster On 03/14/2011 03:48 PM, Luiz Capitulino wrote: > On Mon, 14 Mar 2011 15:41:49 -0500 > Anthony Liguori wrote: > >> On 03/14/2011 03:22 PM, Luiz Capitulino wrote: >>> On Mon, 14 Mar 2011 14:45:13 -0500 >>> Anthony Liguori wrote: >>> >>>> On 03/14/2011 02:37 PM, Luiz Capitulino wrote: >>>>> qerror_abort() only exists for debugging purposes. I won't say its perfect, >>>>> but it's better than nothing and has already saved some time when writing >>>>> new errors. >>>>> >>>>> I'm fine dropping it as long as there's a better replacement, which is >>>>> not the case here. There's even a hunk that replaces qerror_abort() for >>>>> a plain abort(). >>>> Yes, that's the replacement. >>> It's not a good one: it makes the current code a bit worse and we don't know >>> how and when the error classes are going to be replaced. >> Yes, we do, before 0.15.0. > Very optimistic :) I don't doubt you can post patches quickly, but we're > likely going to have fun discussions, respins, tests etc. And all the QAPI > stuff in parallel. Let's have those discussions then because that's what's important. I split this out because I didn't want to have a 40 patch series so I tried to split into two logical series. But the goal is here QAPI. That's what's important to get merged. I'm not terribly interested in merging these changes until we're ready to merge the first round of QAPI. It's a big change, and it's optimistic, but that's what makes it worth trying to do. Regards, Anthony Liguori