From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36886 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzUY6-0000fs-CA for qemu-devel@nongnu.org; Tue, 15 Mar 2011 09:44:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzUY4-0004ba-3u for qemu-devel@nongnu.org; Tue, 15 Mar 2011 09:44:34 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:46067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzUY4-0004bT-11 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 09:44:32 -0400 Received: by iwl42 with SMTP id 42so659030iwl.4 for ; Tue, 15 Mar 2011 06:44:31 -0700 (PDT) Message-ID: <4D7F6D3B.8090803@codemonkey.ws> Date: Tue, 15 Mar 2011 08:44:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit References: <1298460024-23591-1-git-send-email-alevy@redhat.com> <1298460024-23591-5-git-send-email-alevy@redhat.com> <4D7E3236.8050507@redhat.com> <20110314164010.GL31372@playa.tlv.redhat.com> <4D7F5ED0.70401@redhat.com> In-Reply-To: <4D7F5ED0.70401@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Alon Levy , qemu-devel@nongnu.org On 03/15/2011 07:42 AM, Jes Sorensen wrote: > On 03/14/11 17:40, Alon Levy wrote: >> On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: >> >> ok, here is a note where I kinda ignored my own wishes but I want >> to be very clear on them: >> libcacard should not be part of qemu. >> it is here because I once thought it would speed things up. >> >> So I'm not taking it out or anything - it's fine with me that it >> goes into qemu, just as long as it's understood that I'm now maintaining >> another copy of it for usage outside of qemu, in the spice client (or >> any other client for that matter - it will be the same when we do vnc >> support for this). > Hi Alon, > > This bit is somewhat problematic. If QEMU is maintaining a copy of > libcacard, then that has to comply with the QEMU way of doing things. > QEMU cannot rely on various portions in the tree behaving in different > ways. Otherwise it really should be an external library requirement > pulled in by the build. > > I am not sure what is the best way, if it stays in QEMU people will > eventually start making modifications to it, without looking at the > other copy that is being maintained. Two copies is not really practical. QEMU should be the place that owns it and things should be consuming a .so from QEMU. Regards, Anthony Liguori > Alternatively the external apps that build against it should be taught > to link with the QEMU version. > > Cheers, > Jes >