From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39235 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzVbP-00089I-FD
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:52:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzVbO-0002nV-6n
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:52:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzVbN-0002n2-Tu
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:52:02 -0400
Message-ID: <4D7F7CF8.1010809@redhat.com>
Date: Tue, 15 Mar 2011 15:51:36 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit
References: <1298460024-23591-1-git-send-email-alevy@redhat.com>
	<1298460024-23591-5-git-send-email-alevy@redhat.com>
	<4D7E3236.8050507@redhat.com>
	<20110314164010.GL31372@playa.tlv.redhat.com>
	<4D7F5ED0.70401@redhat.com> <4D7F6D3B.8090803@codemonkey.ws>
	<20110315142545.GC10553@playa.tlv.redhat.com>
In-Reply-To: <20110315142545.GC10553@playa.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On 03/15/11 15:25, Alon Levy wrote:
>>> I am not sure what is the best way, if it stays in QEMU people will
>>> > >eventually start making modifications to it, without looking at the
>>> > >other copy that is being maintained.
>> > 
>> > Two copies is not really practical.  QEMU should be the place that
>> > owns it and things should be consuming a .so from QEMU.
>> > 
> My bad - I thought you didn't want this. I can do a patch to make qemu
> build an .so file if configure gets a "--libs", how does that sound?
> right now that would build just libcacard, I guess libqmp too later?
> or perhaps have a separate Makefile (Makefile.libs)? Have you given this
> any thought?

I think the libs should be built by default as part of the build process
and get installed as part of the regular install. Ie. it becomes part of
the QEMU build process, so it requires a QEMU build to build the support
libraries, but they can be packages into separate RPMs/debs by the
distro people.

I don't think we want a --libs option that turns the build process into
only producing the libs.

Cheers,
Jes