From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60630 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzVcs-0000wb-Ni for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzVcq-00038I-SK for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:53:34 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:62880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzVcq-000381-JT for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:53:32 -0400 Received: by iwl42 with SMTP id 42so732050iwl.4 for ; Tue, 15 Mar 2011 07:53:32 -0700 (PDT) Message-ID: <4D7F7D66.8090805@codemonkey.ws> Date: Tue, 15 Mar 2011 09:53:26 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1300192574-32644-1-git-send-email-Jes.Sorensen@redhat.com> <1300192574-32644-3-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce -display argument List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, jan.kiszka@siemens.com On 03/15/2011 09:07 AM, Peter Maydell wrote: > On 15 March 2011 12:36, wrote: >> From: Jes Sorensen >> >> This patch introduces a -display argument which consolidates the >> setting of the display mode. Valid options are: >> sdl/curses/default/serial (serial is equivalent to -nographic) > So I still think that we should not be including any new > -display subargument which mirrors the behaviour of -nographic. > > -display represents an opportunity to provide a set of orthogonal > command line options which affect the handling of particular > devices; it ought to mean "what happens to VGA/video output?", > and should not change the behaviour of any other devices. > > -nographic is effectively a convenience shortcut which changes > the behaviour of several different devices (display, serial, > parallel, at least). It doesn't belong under '-display' from > an orthogonality argument, and people who want it because it > is a shortcut will be better served by the existing '-nographic' > because it's less typing than '-display serial' anyway. Yeah, I think I agree. We shouldn't have a -display nographic. Regards, Anthony Liguori > (Ideally we should document '-nographic' by saying that it > is equivalent to some set of other options including > -display none -serial stdio and whatever else it does.) > > -- PMM