From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33247 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzVeC-0001j5-Cl
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:54:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzVeB-0003bv-Ba
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:54:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzVeA-0003bl-VU
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:54:55 -0400
Message-ID: <4D7F7DA5.8090201@redhat.com>
Date: Tue, 15 Mar 2011 15:54:29 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1300192574-32644-1-git-send-email-Jes.Sorensen@redhat.com>
	<1300192574-32644-3-git-send-email-Jes.Sorensen@redhat.com>
	<4D7F7CFF.2010309@codemonkey.ws>
In-Reply-To: <4D7F7CFF.2010309@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce -display argument
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

On 03/15/11 15:51, Anthony Liguori wrote:
>> +            } else if (strstart(opts, ",window_close=",&nextopt)) {
>> +                opts = nextopt;
>> +                if (strstart(opts, "on",&nextopt)) {
>> +                    no_quit = 0;
>> +                } else if (strstart(opts, "off",&nextopt)) {
>> +                    no_quit = 1;
>> +                } else {
>> +                    goto invalid_display;
>> +                }
>> +            } else {
>> +                goto invalid_display;
>> +            }
>> +            opts = nextopt;
>> +        }
> 
> So the natural reaction here is going to be, "just use QemuOpts".  But
> this is harder than it seems.  The problem is that the VNC options
> inverse the meaning of booleans making conversion of VNC to use QemuOpts
> much harder than it would appear.
> 
> Doing it this way lets us pass the vnc option string directly to
> vnc_display_open().  I don't like it much, but I don't mind it as an
> interim step.

Yeah, it isn't particularly pretty, but it really requires we rewamp the
arguments completely which I think is out of scope for the initial
change here.

Cheers,
Jes