From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48425 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzpWo-0004Jp-0T
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 08:08:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzpWm-0008Bi-VA
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 08:08:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzpWm-0008Be-Lb
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 08:08:36 -0400
Message-ID: <4D80A829.4060409@redhat.com>
Date: Wed, 16 Mar 2011 13:08:09 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1300273214-19586-1-git-send-email-Jes.Sorensen@redhat.com>	<1300273214-19586-3-git-send-email-Jes.Sorensen@redhat.com>
	<AANLkTimNbLJh=j6gW3_E-rPQ1uoHQS=Pv-5CLnLLwBNW@mail.gmail.com>
In-Reply-To: <AANLkTimNbLJh=j6gW3_E-rPQ1uoHQS=Pv-5CLnLLwBNW@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce -display argument
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org

On 03/16/11 12:46, Peter Maydell wrote:
> On 16 March 2011 11:00,  <Jes.Sorensen@redhat.com> wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This patch introduces a -display argument which consolidates the
>> setting of the display mode. Valid options are:
>> sdl/curses/default/serial (serial is equivalent to -nographic)
> 
> You forgot to update the commit message when you took out 'serial'...

Good catch, thanks!

>> +Pick the SDL display option.
> 
> How about "Display video output via SDL (usually in a separate graphics
> window; see the SDL documentation for other possibilities)." ?

Looks good to me.

>> +@item curses
>> +Pick the curses display option. Normally, QEMU uses SDL to display the
>> +VGA output.  With this option, QEMU can display the VGA output when in
>> +text mode using a curses/ncurses interface.  Nothing is displayed in
>> +graphical mode.
>> +@end table
>> +ETEXI
> 
> This kind of implies that the only kind of video is VGA, which isn't
> true.
> 
> "Display video output via curses. For graphics device models which
> support a text mode, QEMU can display this output using a curses/ncurses
> interface. Nothing is displayed when the graphics device is in
> graphical mode or if the graphics device does not support a text mode.
> Generally only the VGA device models support text mode."

Ditto

Cheers,
Jes