From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzr49-0006Ot-Jc for qemu-devel@nongnu.org; Wed, 16 Mar 2011 09:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzr48-0005L8-3a for qemu-devel@nongnu.org; Wed, 16 Mar 2011 09:47:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46651 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzr47-0005Kw-R9 for qemu-devel@nongnu.org; Wed, 16 Mar 2011 09:47:08 -0400 Message-ID: <4D80BF4F.8030406@suse.de> Date: Wed, 16 Mar 2011 14:46:55 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au> <1300251423-6715-4-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1300251423-6715-4-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org On 03/16/2011 05:56 AM, David Gibson wrote: > From: David Gibson > > PowerPC and POWER chips since the POWER4 and 970 have a special > hypervisor mode, and a corresponding form of the system call > instruction which traps to the hypervisor. > > qemu currently has stub implementations of hypervisor mode. That > is, the outline is there to allow qemu to run a PowerPC hypervisor > under emulation. There are a number of details missing so this > won't actually work at present, but the idea is there. > > What there is no provision at all, is for qemu to instead emulate > the hypervisor itself. That is to have hypercalls trap into qemu > and their result be emulated from qemu, rather than running > hypervisor code within the emulated system. > > Hypervisor hardware aware KVM implementations are in the works and > it would be useful for debugging and development to also allow > full emulation of the same para-virtualized guests as such a KVM. > > Therefore, this patch adds a hook which will allow a machine to > set up emulation of hypervisor calls. > > Signed-off-by: David Gibson > --- > target-ppc/cpu.h | 2 ++ > target-ppc/helper.c | 4 ++++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h > index a20c132..eaddc27 100644 > --- a/target-ppc/cpu.h > +++ b/target-ppc/cpu.h > @@ -692,6 +692,8 @@ struct CPUPPCState { > int bfd_mach; > uint32_t flags; > uint64_t insns_flags; > + void (*emulate_hypercall)(CPUState *, void *); > + void *hcall_opaque; > > int error_code; > uint32_t pending_interrupts; > diff --git a/target-ppc/helper.c b/target-ppc/helper.c > index 2094ca3..19aa067 100644 > --- a/target-ppc/helper.c > +++ b/target-ppc/helper.c > @@ -2152,6 +2152,10 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp) > case POWERPC_EXCP_SYSCALL: /* System call exception */ > dump_syscall(env); > lev = env->error_code; > + if ((lev == 1)&& env->emulate_hypercall) { > + env->emulate_hypercall(env, env->hcall_opaque); > + return; > + } Tabs! Please go through all your patches and make sure there are no tabs in there :(. Alex