From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39282 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzuNh-0002ko-Na
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 13:19:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PzuNg-0005uM-CZ
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 13:19:33 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56497 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PzuNg-0005u8-7F
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 13:19:32 -0400
Message-ID: <4D80F122.4050101@suse.de>
Date: Wed, 16 Mar 2011 18:19:30 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait
	features
References: <1300285539-30905-1-git-send-email-adam@os.inf.tu-dresden.de>
In-Reply-To: <1300285539-30905-1-git-send-email-adam@os.inf.tu-dresden.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org

On 03/16/2011 03:25 PM, Adam Lackorzynski wrote:
> CPUID claims that extended monitor/mwait features are available but the
> mwait helper instantly raises a GPF if they are used. Thus do not announce
> that the extension are available.

Would be better to just implement mwait, no?


Alex

> Signed-off-by: Adam Lackorzynski<adam@os.inf.tu-dresden.de>
> ---
>   target-i386/cpuid.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> index 5382a28..28275a6 100644
> --- a/target-i386/cpuid.c
> +++ b/target-i386/cpuid.c
> @@ -1104,7 +1104,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
>           /* mwait info: needed for Core compatibility */
>           *eax = 0; /* Smallest monitor-line size in bytes */
>           *ebx = 0; /* Largest monitor-line size in bytes */
> -        *ecx = CPUID_MWAIT_EMX | CPUID_MWAIT_IBE;
> +        *ecx = 0; /* Supported extensions */
>           *edx = 0;
>           break;
>       case 6: