From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46053 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzxCL-0006WP-F4
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:20:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PzxCK-0005IA-4u
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:20:01 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:43026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PzxCJ-0005I6-UK
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:20:00 -0400
Received: by iwl42 with SMTP id 42so2328868iwl.4
	for <qemu-devel@nongnu.org>; Wed, 16 Mar 2011 13:19:59 -0700 (PDT)
Message-ID: <4D811B68.4020307@codemonkey.ws>
Date: Wed, 16 Mar 2011 15:19:52 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 24/26] Implement PAPR virtual SCSI
	interface (ibmvscsi)
References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au>	<1300251423-6715-25-git-send-email-david@gibson.dropbear.id.au>	<4D80E852.5020109@suse.de>
	<1300306127.22236.1177.camel@pasglop>
In-Reply-To: <1300306127.22236.1177.camel@pasglop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Gibson <david@gibson.dropbear.id.au>, paulus@samba.org, Alexander Graf <agraf@suse.de>, anton@samba.org, qemu-devel@nongnu.org

On 03/16/2011 03:08 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-03-16 at 17:41 +0100, Alexander Graf wrote:
>
>>> +/*
>>> + * Common MAD header
>>> + */
>>> +struct mad_common {
>>> +    uint32_t type;
>>> +    uint16_t status;
>>> +    uint16_t length;
>>> +    uint64_t tag;
>> Is this an in-memory representation? If so, it should be packed, right?
>> Same goes for the ones below.
> Well, all the fields are naturally aligned, as is the structure itself,
> do we really need to pack ?

No.

Regards,

Anthony Liguori

> Cheers,
> Ben.
>
>
>