From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40262 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzytE-0001FV-TF
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 18:08:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PzytD-0002P2-Nd
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 18:08:24 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:38212)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PzytD-0002Ox-Kd
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 18:08:23 -0400
Received: by iym7 with SMTP id 7so2434284iym.4
	for <qemu-devel@nongnu.org>; Wed, 16 Mar 2011 15:08:23 -0700 (PDT)
Message-ID: <4D8134CF.6060104@codemonkey.ws>
Date: Wed, 16 Mar 2011 17:08:15 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 16/26] Implement hcall based RTAS for pSeries
	machines
References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au>
	<1300251423-6715-17-git-send-email-david@gibson.dropbear.id.au>
In-Reply-To: <1300251423-6715-17-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: paulus@samba.org, agraf@suse.de, anton@samba.org, qemu-devel@nongnu.org

On 03/15/2011 11:56 PM, David Gibson wrote:
> diff --git a/hw/spapr_rtas.c b/hw/spapr_rtas.c
> new file mode 100644
> index 0000000..c606018
> --- /dev/null
> +++ b/hw/spapr_rtas.c
> @@ -0,0 +1,104 @@

Needs copyright

Regards,

Anthony Liguori

> +#include "cpu.h"
> +#include "sysemu.h"
> +#include "qemu-char.h"
> +#include "hw/qdev.h"
> +#include "device_tree.h"
> +
> +#include "hw/spapr.h"
> +#include "hw/spapr_vio.h"
> +
> +#include<libfdt.h>
> +
> +#define TOKEN_BASE      0x2000
> +#define TOKEN_MAX       0x100
> +
> +static struct rtas_call {
> +    const char *name;
> +    spapr_rtas_fn fn;
> +} rtas_table[TOKEN_MAX];
> +
> +struct rtas_call *rtas_next = rtas_table;
> +
> +target_ulong spapr_rtas_call(sPAPREnvironment *spapr,
> +                             uint32_t token, uint32_t nargs, target_ulong args,
> +                             uint32_t nret, target_ulong rets)
> +{
> +    if ((token>= TOKEN_BASE)
> +&&  ((token - TOKEN_BASE)<  TOKEN_MAX)) {
> +        struct rtas_call *call = rtas_table + (token - TOKEN_BASE);
> +
> +        if (call->fn) {
> +            call->fn(spapr, token, nargs, args, nret, rets);
> +            return H_SUCCESS;
> +        }
> +    }
> +
> +    fprintf(stderr, "Unknown RTAS token 0x%x\n", token);
> +    rtas_st(rets, 0, -3);
> +    return H_PARAMETER;
> +}
> +
> +void spapr_rtas_register(const char *name, spapr_rtas_fn fn)
> +{
> +    assert(rtas_next<  (rtas_table + TOKEN_MAX));
> +
> +    rtas_next->name = name;
> +    rtas_next->fn = fn;
> +
> +    rtas_next++;
> +}
> +
> +int spapr_rtas_device_tree_setup(void *fdt, target_phys_addr_t rtas_addr,
> +                                 target_phys_addr_t rtas_size)
> +{
> +    int ret;
> +    int i;
> +
> +    ret = fdt_add_mem_rsv(fdt, rtas_addr, rtas_size);
> +    if (ret<  0) {
> +        fprintf(stderr, "Couldn't add RTAS reserve entry: %s\n",
> +                fdt_strerror(ret));
> +        return ret;
> +    }
> +
> +    ret = qemu_devtree_setprop_cell(fdt, "/rtas", "linux,rtas-base",
> +                                    rtas_addr);
> +    if (ret<  0) {
> +        fprintf(stderr, "Couldn't add linux,rtas-base property: %s\n",
> +                fdt_strerror(ret));
> +        return ret;
> +    }
> +
> +    ret = qemu_devtree_setprop_cell(fdt, "/rtas", "linux,rtas-entry",
> +                                    rtas_addr);
> +    if (ret<  0) {
> +        fprintf(stderr, "Couldn't add linux,rtas-entry property: %s\n",
> +                fdt_strerror(ret));
> +        return ret;
> +    }
> +
> +    ret = qemu_devtree_setprop_cell(fdt, "/rtas", "rtas-size",
> +                                    rtas_size);
> +    if (ret<  0) {
> +        fprintf(stderr, "Couldn't add rtas-size property: %s\n",
> +                fdt_strerror(ret));
> +        return ret;
> +    }
> +
> +    for (i = 0; i<  TOKEN_MAX; i++) {
> +        struct rtas_call *call =&rtas_table[i];
> +
> +        if (!call->fn) {
> +            continue;
> +        }
> +
> +        ret = qemu_devtree_setprop_cell(fdt, "/rtas", call->name, i + TOKEN_BASE);
> +        if (ret<  0) {
> +            fprintf(stderr, "Couldn't add rtas token for %s: %s\n",
> +                    call->name, fdt_strerror(ret));
> +            return ret;
> +        }
> +
> +    }
> +    return 0;
> +}
> diff --git a/pc-bios/spapr-rtas.bin b/pc-bios/spapr-rtas.bin
> new file mode 100644
> index 0000000000000000000000000000000000000000..eade9c0e8ff0fd3071e3a6638a11c1a2e9a47152
> GIT binary patch
> literal 20
> bcmb<Pk*=^wC@M)vPAqm|U{LaFU{C-6M#cr<
>
> literal 0
> HcmV?d00001
>