From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48795 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0ASR-0006ck-OV
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 06:29:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q0ASQ-0007Qm-PK
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 06:29:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q0ASQ-0007QU-6B
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 06:29:30 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2HATTXF012914
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 17 Mar 2011 06:29:29 -0400
Message-ID: <4D81E26F.7060506@redhat.com>
Date: Thu, 17 Mar 2011 11:29:03 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks,
	replace with pipe
References: <1300290769-31155-1-git-send-email-alevy@redhat.com>
	<1300290769-31155-5-git-send-email-alevy@redhat.com>
	<4D80E9E9.7000505@redhat.com>
	<20110317093206.GL7413@playa.tlv.redhat.com>
	<4D81D8FB.6080009@redhat.com>
	<20110317102720.GO7413@playa.tlv.redhat.com>
In-Reply-To: <20110317102720.GO7413@playa.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: hdegoede@redhat.com, uril@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com

On 03/17/11 11:27, Alon Levy wrote:
> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote:
>>> Same for the asserts below, writes are from spice server thread, reads
>>> are in iothread.
>>
>> But shouldn't this make it try to reconnect? Even if the reconnect
>> fails, it shouldn't kill the guest IMHO.
> 
> reconnect? between two threads in the qemu process? why would the write
> fail to begin with? this is like saying if I'm failing a kvm ioctl I should
> just retry.

Ah ok, I missed that part, somehow I had in my mind it was two different
processes, despite you mentioning threads.

Still if gfx handling fails, it shouldn't nuke the guest.

Cheers,
Jes