From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57085 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0D1c-0008Pm-4p for qemu-devel@nongnu.org; Thu, 17 Mar 2011 09:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0D1J-0000kh-9E for qemu-devel@nongnu.org; Thu, 17 Mar 2011 09:13:42 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:34842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0D1J-0000kY-0r for qemu-devel@nongnu.org; Thu, 17 Mar 2011 09:13:41 -0400 Received: by yxk8 with SMTP id 8so1319393yxk.4 for ; Thu, 17 Mar 2011 06:13:40 -0700 (PDT) Message-ID: <4D8208F7.1040400@codemonkey.ws> Date: Thu, 17 Mar 2011 08:13:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics) References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au> <1300251423-6715-19-git-send-email-david@gibson.dropbear.id.au> <4D8136A7.2040706@codemonkey.ws> <20110317013459.GD1105@yookeroo> In-Reply-To: <20110317013459.GD1105@yookeroo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de, qemu-devel@nongnu.org, paulus@samba.org, anton@samba.org On 03/16/2011 08:34 PM, David Gibson wrote: > >>> +/* >>> + * ICP: Presentation layer >>> + */ >>> + >>> +struct icp_server_state { >>> + uint32_t cppr :8; >>> + uint32_t xisr :24; >> No real reason to use bitfields here. > Well.. in the hardware xics implementation, CPPR and XISR are > considered fields of the one 32-bit register, XIRR. Matching that is > why I have the bitfield. Bitfields don't work well with the way we save device state. Regards, Anthony Liguori