From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: hdegoede@redhat.com, uril@redhat.com, qemu-devel@nongnu.org,
gleb@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe
Date: Thu, 17 Mar 2011 15:19:28 +0100 [thread overview]
Message-ID: <4D821870.8020502@redhat.com> (raw)
In-Reply-To: <20110317104541.GQ7413@playa.tlv.redhat.com>
On 03/17/11 11:45, Alon Levy wrote:
> On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote:
>> On 03/17/11 11:27, Alon Levy wrote:
>>> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote:
>>>>> Same for the asserts below, writes are from spice server thread, reads
>>>>> are in iothread.
>>>>
>>>> But shouldn't this make it try to reconnect? Even if the reconnect
>>>> fails, it shouldn't kill the guest IMHO.
>>>
>>> reconnect? between two threads in the qemu process? why would the write
>>> fail to begin with? this is like saying if I'm failing a kvm ioctl I should
>>> just retry.
>>
>> Ah ok, I missed that part, somehow I had in my mind it was two different
>> processes, despite you mentioning threads.
>>
>> Still if gfx handling fails, it shouldn't nuke the guest.
>
> ok, try to apply that logic to any other device - network, usb, etc., I don't
> think it holds.
Maybe I am looking at the wrong angle - I would think that is network or
usb breaks, we would still keep running, and for gfx the guest should be
able to keep running even if the monitor is disconnected.
It's not a big issue so if you feel it is fine as is, I won't object.
Cheers,
Jes
next prev parent reply other threads:[~2011-03-17 14:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 15:52 [Qemu-devel] [PATCH v3 0/4] qxl: implement vga mode without locks Alon Levy
2011-03-16 15:52 ` [Qemu-devel] [PATCH v3 1/4] qxl/spice-display: move pipe to ssd Alon Levy
2011-03-16 15:58 ` Hans de Goede
2011-03-16 16:39 ` Jes Sorensen
2011-03-16 16:42 ` Alon Levy
2011-03-16 15:52 ` [Qemu-devel] [PATCH v3 2/4] qxl: implement get_command in vga mode without locks Alon Levy
2011-03-16 16:00 ` [Qemu-devel] " Hans de Goede
2011-03-16 15:52 ` [Qemu-devel] [PATCH v3 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher Alon Levy
2011-03-16 16:01 ` [Qemu-devel] " Hans de Goede
2011-03-16 15:52 ` [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe Alon Levy
2011-03-16 16:02 ` [Qemu-devel] " Hans de Goede
2011-03-16 16:48 ` [Qemu-devel] " Jes Sorensen
2011-03-17 9:32 ` Alon Levy
2011-03-17 9:48 ` Jes Sorensen
2011-03-17 10:27 ` Alon Levy
2011-03-17 10:29 ` Jes Sorensen
2011-03-17 10:45 ` Alon Levy
2011-03-17 14:19 ` Jes Sorensen [this message]
2011-03-17 15:08 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D821870.8020502@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=gleb@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).