From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55283 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0FHy-0003CK-4R for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0FHw-0000nQ-3J for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:39:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0FHv-0000n8-NQ for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:39:00 -0400 Message-ID: <4D822B94.9050001@redhat.com> Date: Thu, 17 Mar 2011 16:41:08 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive References: <4D81BF12.4020500@msgid.tls.msk.ru> <4D822301.6050206@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Michael Tokarev , qemu-devel@nongnu.org Am 17.03.2011 16:33, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 17.03.2011 08:58, schrieb Michael Tokarev: >>> Trivial patch. I've sent it yesterday but somehow it didn't >>> reach the list. >>> >>> This fixes the problem when qemu continues even if -drive specification >>> is somehow invalid, resulting in a mess. Applicable for both current >>> master and for stable-0.14 (and 0.13 and 0.12 as well). >>> >>> The prob can actually be seriuos: when you start guest with two drives >>> and make an error in the specification of one of them, and the guest >>> has something like a raid array on the two drives, guest may start failing >>> that array or kick "missing" drives which may result in a mess - this is >>> what actually happened to me, I did't want a resync at all, and a resync >>> resulted in re-writing (and allocating) a 4TB virtual drive I used for >>> testing, which in turn resulted in my filesystem filling up and whole >>> thing failing badly. Yes it was just testing VM, I experimented with >>> larger raid arrays, but the end result was quite, well, unexpected. >>> >>> Thanks! >>> >>> Signed-off-by: Michael Tokarev >> >> Before I got a message like this and the guest started anyway: >> >> qemu-system-x86_64: -drive asdfj: Invalid parameter 'asdfj' >> >> Now it exits like it should, but I don't get an error message any more. > [...] > > Are you sure? I still get the error message in my testing. You're right. Instead of using git am to apply the patch, I just edited vl.c manually and probably messed up. The patch works. So it's only the braces. Kevin