From: Michael Tokarev <mjt@tls.msk.ru>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive
Date: Thu, 17 Mar 2011 18:49:49 +0300 [thread overview]
Message-ID: <4D822D9D.50907@msgid.tls.msk.ru> (raw)
In-Reply-To: <4D822301.6050206@redhat.com>
17.03.2011 18:04, Kevin Wolf wrote:
> Am 17.03.2011 08:58, schrieb Michael Tokarev:
[]
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2098,7 +2098,8 @@ int main(int argc, char **argv, char **envp)
>> HD_OPTS);
>> break;
>> case QEMU_OPTION_drive:
>> - drive_def(optarg);
>> + if (drive_def(optarg) == NULL)
>> + exit(1);
>
> Coding style requires braces here.
I'll just stick it into debian package. I'm not going
to change all the other braces like this around that place.
Thanks.
/mjt
next prev parent reply other threads:[~2011-03-17 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 7:58 [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive Michael Tokarev
2011-03-17 13:51 ` Markus Armbruster
2011-03-17 14:28 ` Michael Tokarev
2011-03-17 15:35 ` Markus Armbruster
2011-03-17 15:04 ` Kevin Wolf
2011-03-17 15:33 ` Markus Armbruster
2011-03-17 15:41 ` Kevin Wolf
2011-03-17 15:49 ` Michael Tokarev [this message]
2011-03-17 15:55 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D822D9D.50907@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).