From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60549 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0XF4-0004dN-AT
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 06:49:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Q0XF3-0000UJ-7N
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 06:49:14 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:48983)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Q0XF2-0000To-Vv
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 06:49:13 -0400
Message-ID: <4D833890.8040403@web.de>
Date: Fri, 18 Mar 2011 11:48:48 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4D73A3BD.2000405@web.de>
In-Reply-To: <4D73A3BD.2000405@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigAFF995D3BFD80A247AAF6407"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] i8254: Fix migration from older versions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigAFF995D3BFD80A247AAF6407
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-03-06 16:09, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> qdev conversion broke migration as the previous version used vmstate
> instance IDs derived from the iobase. Fix it by registering a legacy
> alias.
>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/i8254.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>=20
> diff --git a/hw/i8254.c b/hw/i8254.c
> index eaf5d3e..47c9d73 100644
> --- a/hw/i8254.c
> +++ b/hw/i8254.c
> @@ -520,6 +520,8 @@ static int pit_initfn(ISADevice *dev)
>      register_ioport_read(pit->iobase, 3, 1, pit_ioport_read, pit);
>      isa_init_ioport(dev, pit->iobase);
> =20
> +    qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
> +
>      return 0;
>  }
> =20

This bug is still open.

Jan


--------------enigAFF995D3BFD80A247AAF6407
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk2DOJAACgkQitSsb3rl5xSIOACeMolW/lrsFdAl2Y4GDcA3+MtR
SBkAnRxXJtdEOVonW9RS2WCeyWWU2yPJ
=I6aa
-----END PGP SIGNATURE-----

--------------enigAFF995D3BFD80A247AAF6407--