* [Qemu-devel] [PATCH] i8254: Fix migration from older versions
@ 2011-03-06 15:09 Jan Kiszka
2011-03-18 10:48 ` [Qemu-devel] " Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2011-03-06 15:09 UTC (permalink / raw)
To: qemu-devel, Blue Swirl
From: Jan Kiszka <jan.kiszka@siemens.com>
qdev conversion broke migration as the previous version used vmstate
instance IDs derived from the iobase. Fix it by registering a legacy
alias.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/i8254.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/i8254.c b/hw/i8254.c
index eaf5d3e..47c9d73 100644
--- a/hw/i8254.c
+++ b/hw/i8254.c
@@ -520,6 +520,8 @@ static int pit_initfn(ISADevice *dev)
register_ioport_read(pit->iobase, 3, 1, pit_ioport_read, pit);
isa_init_ioport(dev, pit->iobase);
+ qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
+
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH] i8254: Fix migration from older versions
2011-03-06 15:09 [Qemu-devel] [PATCH] i8254: Fix migration from older versions Jan Kiszka
@ 2011-03-18 10:48 ` Jan Kiszka
2011-03-19 8:38 ` Blue Swirl
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2011-03-18 10:48 UTC (permalink / raw)
To: qemu-devel, Blue Swirl
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On 2011-03-06 16:09, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> qdev conversion broke migration as the previous version used vmstate
> instance IDs derived from the iobase. Fix it by registering a legacy
> alias.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/i8254.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/i8254.c b/hw/i8254.c
> index eaf5d3e..47c9d73 100644
> --- a/hw/i8254.c
> +++ b/hw/i8254.c
> @@ -520,6 +520,8 @@ static int pit_initfn(ISADevice *dev)
> register_ioport_read(pit->iobase, 3, 1, pit_ioport_read, pit);
> isa_init_ioport(dev, pit->iobase);
>
> + qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
> +
> return 0;
> }
>
This bug is still open.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] i8254: Fix migration from older versions
2011-03-18 10:48 ` [Qemu-devel] " Jan Kiszka
@ 2011-03-19 8:38 ` Blue Swirl
0 siblings, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2011-03-19 8:38 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
Thanks, applied.
On Fri, Mar 18, 2011 at 12:48 PM, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2011-03-06 16:09, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> qdev conversion broke migration as the previous version used vmstate
>> instance IDs derived from the iobase. Fix it by registering a legacy
>> alias.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> hw/i8254.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/i8254.c b/hw/i8254.c
>> index eaf5d3e..47c9d73 100644
>> --- a/hw/i8254.c
>> +++ b/hw/i8254.c
>> @@ -520,6 +520,8 @@ static int pit_initfn(ISADevice *dev)
>> register_ioport_read(pit->iobase, 3, 1, pit_ioport_read, pit);
>> isa_init_ioport(dev, pit->iobase);
>>
>> + qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
>> +
>> return 0;
>> }
>>
>
> This bug is still open.
>
> Jan
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-19 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-06 15:09 [Qemu-devel] [PATCH] i8254: Fix migration from older versions Jan Kiszka
2011-03-18 10:48 ` [Qemu-devel] " Jan Kiszka
2011-03-19 8:38 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).