From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40626 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0iL2-0007jF-S2
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 18:40:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Q0iKy-0005A9-7W
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 18:40:08 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:58391)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Q0iKx-00059B-Oz
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 18:40:04 -0400
Message-ID: <4D83DF36.5020903@mail.berlios.de>
Date: Fri, 18 Mar 2011 23:39:50 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1300039252-27156-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1300039252-27156-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] w32: Add missing functions
	qemu_mutex_destroy, qemu_cond_destroy
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

Am 13.03.2011 19:00, schrieb Stefan Weil:
> These functions were missing in commit
> 9257d46d55f1fe4e8209be9a6870e339ac3266fe.
>
> Both functions are needed for compilations with
> configuration --enable-vnc-thread.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> qemu-thread-win32.c | 21 +++++++++++++++++++++
> 1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
> index 2edcb1a..2d2d5ab 100644
> --- a/qemu-thread-win32.c
> +++ b/qemu-thread-win32.c
> @@ -33,6 +33,12 @@ void qemu_mutex_init(QemuMutex *mutex)
> InitializeCriticalSection(&mutex->lock);
> }
>
> +void qemu_mutex_destroy(QemuMutex *mutex)
> +{
> + assert(mutex->owner == 0);
> + DeleteCriticalSection(&mutex->lock);
> +}
> +
> void qemu_mutex_lock(QemuMutex *mutex)
> {
> EnterCriticalSection(&mutex->lock);
> @@ -80,6 +86,21 @@ void qemu_cond_init(QemuCond *cond)
> }
> }
>
> +void qemu_cond_destroy(QemuCond *cond)
> +{
> + BOOL result;
> + result = CloseHandle(cond->continue_event);
> + if (!result) {
> + error_exit(GetLastError(), __func__);
> + }
> + cond->continue_event = 0;
> + result = CloseHandle(cond->sema);
> + if (!result) {
> + error_exit(GetLastError(), __func__);
> + }
> + cond->sema = 0;
> +}
> +
> void qemu_cond_signal(QemuCond *cond)
> {
> DWORD result;

No comments? Why is is so difficult to get compilation problems fixed?