qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] vmmouse: Fix initialization
@ 2011-03-21  9:52 Jan Kiszka
  2011-03-22  6:45 ` Aurelien Jarno
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2011-03-21  9:52 UTC (permalink / raw)
  To: Blue Swirl, qemu-devel

Latest refactorings left vmmouse nonfunctional behind. Fix it by adding
the required device initialization.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/pc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index 4d67d9f..6939c04 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1142,6 +1142,7 @@ void pc_basic_device_init(qemu_irq *isa_irq,
     vmmouse = isa_try_create("vmmouse");
     if (vmmouse) {
         qdev_prop_set_ptr(&vmmouse->qdev, "ps2_mouse", i8042);
+        qdev_init_nofail(&vmmouse->qdev);
     }
     port92 = isa_create_simple("port92");
     port92_init(port92, &a20_line[1]);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] vmmouse: Fix initialization
  2011-03-21  9:52 [Qemu-devel] [PATCH] vmmouse: Fix initialization Jan Kiszka
@ 2011-03-22  6:45 ` Aurelien Jarno
  0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-03-22  6:45 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Blue Swirl, qemu-devel

On Mon, Mar 21, 2011 at 10:52:24AM +0100, Jan Kiszka wrote:
> Latest refactorings left vmmouse nonfunctional behind. Fix it by adding
> the required device initialization.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/pc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/hw/pc.c b/hw/pc.c
> index 4d67d9f..6939c04 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1142,6 +1142,7 @@ void pc_basic_device_init(qemu_irq *isa_irq,
>      vmmouse = isa_try_create("vmmouse");
>      if (vmmouse) {
>          qdev_prop_set_ptr(&vmmouse->qdev, "ps2_mouse", i8042);
> +        qdev_init_nofail(&vmmouse->qdev);
>      }
>      port92 = isa_create_simple("port92");
>      port92_init(port92, &a20_line[1]);
> -- 
> 1.7.1
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-22  7:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-21  9:52 [Qemu-devel] [PATCH] vmmouse: Fix initialization Jan Kiszka
2011-03-22  6:45 ` Aurelien Jarno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).