qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [arm] Integrator/CP keyboard layout
@ 2011-03-21 23:03 Jakub Jermar
  2011-03-22 10:24 ` Peter Maydell
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jermar @ 2011-03-21 23:03 UTC (permalink / raw)
  To: qemu-devel; +Cc: vineethrp

Hello,

I noticed that the layout of the PL050 keyboard used on Integrator/CP
incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The
current layout used in Qemu's model of Integrator/CP is the standard PC
layout. What puzzles me is whether this was a fix or a regression. Does
anybody know what was the motivation for that change?

Thanks,
Jakub

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [arm] Integrator/CP keyboard layout
  2011-03-21 23:03 [Qemu-devel] [arm] Integrator/CP keyboard layout Jakub Jermar
@ 2011-03-22 10:24 ` Peter Maydell
  2011-03-22 15:19   ` jakub
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2011-03-22 10:24 UTC (permalink / raw)
  To: Jakub Jermar; +Cc: qemu-devel, vineethrp

On 21 March 2011 23:03, Jakub Jermar <jakub@jermar.eu> wrote:
> I noticed that the layout of the PL050 keyboard used on Integrator/CP
> incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The
> current layout used in Qemu's model of Integrator/CP is the standard PC
> layout. What puzzles me is whether this was a fix or a regression. Does
> anybody know what was the motivation for that change?

The PL050 is just a PS/2 keyboard (or mouse) interface -- so
it doesn't have any control over the keyboard layout (either
in hardware or in qemu's model); I guess you're seeing the
effects of a non-ARM-specific change to PS/2 keyboard handling.

-- PMM

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [arm] Integrator/CP keyboard layout
  2011-03-22 10:24 ` Peter Maydell
@ 2011-03-22 15:19   ` jakub
  2011-03-22 15:50     ` Peter Maydell
  0 siblings, 1 reply; 5+ messages in thread
From: jakub @ 2011-03-22 15:19 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, vineethrp

Quoting Peter Maydell <peter.maydell@linaro.org>:

> On 21 March 2011 23:03, Jakub Jermar <jakub@jermar.eu> wrote:
>> I noticed that the layout of the PL050 keyboard used on Integrator/CP
>> incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The
>> current layout used in Qemu's model of Integrator/CP is the standard PC
>> layout. What puzzles me is whether this was a fix or a regression. Does
>> anybody know what was the motivation for that change?
>
> The PL050 is just a PS/2 keyboard (or mouse) interface -- so
> it doesn't have any control over the keyboard layout (either
> in hardware or in qemu's model); I guess you're seeing the
> effects of a non-ARM-specific change to PS/2 keyboard handling.

Hi Peter,

I would tend to think that there is only one correct set of key codes that the
keyboard on Integrator/CP may generate. And the question is whether  
the current
behavior is the correct one.

We can observe this with HelenOS/arm32/icp. We captured the key codes of the
layout from the old Qemu and programmed our driver to work with, but with the
new Qemu, the key codes / the layout changed and the driver sends wrong codes.

Jakub

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [arm] Integrator/CP keyboard layout
  2011-03-22 15:19   ` jakub
@ 2011-03-22 15:50     ` Peter Maydell
  2011-03-22 16:44       ` jakub
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2011-03-22 15:50 UTC (permalink / raw)
  To: jakub; +Cc: qemu-devel, vineethrp

On 22 March 2011 15:19,  <jakub@jermar.eu> wrote:
> Quoting Peter Maydell <peter.maydell@linaro.org>:
>> On 21 March 2011 23:03, Jakub Jermar <jakub@jermar.eu> wrote:
>>> I noticed that the layout of the PL050 keyboard used on Integrator/CP
>>> incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The
>>> current layout used in Qemu's model of Integrator/CP is the standard PC
>>> layout. What puzzles me is whether this was a fix or a regression. Does
>>> anybody know what was the motivation for that change?
>>
>> The PL050 is just a PS/2 keyboard (or mouse) interface -- so
>> it doesn't have any control over the keyboard layout (either
>> in hardware or in qemu's model); I guess you're seeing the
>> effects of a non-ARM-specific change to PS/2 keyboard handling.

> I would tend to think that there is only one correct set of key codes
> that the keyboard on Integrator/CP may generate.

Why do you think this? The keyboard isn't built in to the hardware,
so the set of keycodes you get depends on the keyboard, not the
Integrator/CP. (Conversely, you should get the same set of keycodes
for an Integrator/CP as you would for a PC model, so if there was
a difference in 0.10.5 this is a progression, not a regression.)

-- PMM

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [arm] Integrator/CP keyboard layout
  2011-03-22 15:50     ` Peter Maydell
@ 2011-03-22 16:44       ` jakub
  0 siblings, 0 replies; 5+ messages in thread
From: jakub @ 2011-03-22 16:44 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, vineethrp

Quoting Peter Maydell <peter.maydell@linaro.org>:
>> I would tend to think that there is only one correct set of key codes
>> that the keyboard on Integrator/CP may generate.
>
> Why do you think this? The keyboard isn't built in to the hardware,
> so the set of keycodes you get depends on the keyboard, not the
> Integrator/CP. (Conversely, you should get the same set of keycodes
> for an Integrator/CP as you would for a PC model, so if there was
> a difference in 0.10.5 this is a progression, not a regression.)

It was just a guess. The problem is that I never saw a real Integrator/CP and
don't know whether the keyboard is fixed or not. The key map which we  
originally
used was reverse engineered from the old Qemu. Now it looks like we  
will simply
dump it and use the PC keyboard for it.

Thanks for making this clear.

Jakub

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-03-22 16:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-21 23:03 [Qemu-devel] [arm] Integrator/CP keyboard layout Jakub Jermar
2011-03-22 10:24 ` Peter Maydell
2011-03-22 15:19   ` jakub
2011-03-22 15:50     ` Peter Maydell
2011-03-22 16:44       ` jakub

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).