From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40887 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1yUo-0004Lb-9C for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:07:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1yUn-0003Yt-9h for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:07:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1yUn-0003Yg-0b for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:07:25 -0400 Message-ID: <4D8874D6.9070704@redhat.com> Date: Tue, 22 Mar 2011 12:07:18 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1270297532.421733.1300463647982.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> In-Reply-To: <1270297532.421733.1300463647982.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/3] alleviate time drift with HPET periodic timers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ulrich Obergfell Cc: aliguori@us.ibm.com, kvm , Jan Kiszka , qemu-devel@nongnu.org, gcosta@redhat.com On 03/18/2011 05:54 PM, Ulrich Obergfell wrote: > Please review and please comment. Some procedural remarks: - put all patches in the same thread. 'git send-email' can do that automatically for you. This really helps reviewers, at least with some email readers - give individual patches meaningful subjects (not 'alleviate time drift with HPET periodic timers' for all patches + subject letter) - reduce the amount of ifdefs in your patches -- error compiling committee.c: too many arguments to function