[Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET periodic timers

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2011-03-22 11:03, Ulrich Obergfell wrote:
> 
>>> Part 3 of the patch implements the following options for the
>>> 'configure' script.
>>>
>>> --disable-hpet-driftfix
>>> --enable-hpet-driftfix
>>
>> I see no benefit in this configurability. Just make the driftfix
>> unconditionally available, runtime-disabled by default for now until it
>> matured and there is no downside in enabling it all the time.
> 
> 
> Many Thanks Jan,
> 
> I enclosed the code in '#ifdef CONFIG_HPET_DRIFTFIX ... #endif'
> so that it can be easily identified (and removed if the generic API
> would be implemented some day). Since the ifdef's are already there
> I added the configuration option for convenience. As you don't see
> any benefit in this option, I can remove that part of the patch.
> However, I'd suggest to keep the ifdef's and do the following:
> 
> - Rename to '#ifdef HPET_DRIFTFIX ... #endif' to make it clear that
>   this is not controlled via a configuration option.
> 
> - Add '#define HPET_DRIFTFIX' to hw/hpet_emul.h.
> 
> Do you agree ?

Thanks to versioning control and feature-oriented commits, it's not very
hard to identify what code changes relate to which feature additions. So
I still don't see a need for that.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux