qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled
Date: Tue, 22 Mar 2011 12:40:51 +0200	[thread overview]
Message-ID: <4D887CB3.6010505@redhat.com> (raw)
In-Reply-To: <4D8878BE.5070102@linux.vnet.ibm.com>

On 03/22/2011 12:23 PM, Stefan Berger wrote:
> On 03/22/2011 05:28 AM, Avi Kivity wrote:
>> On 03/22/2011 03:46 AM, Anthony Liguori wrote:
>>> On 03/21/2011 07:25 PM, Stefan Berger wrote:
>>>> On 03/15/2011 10:53 AM, Juan Quintela wrote:
>>>>> commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c
>>>>>
>>>>> only contains half of the fix.  It forgots the save state fix for
>>>>> UINT8 indexes.
>>>>>
>>>>> Anthony, please apply, without this migration using hpet is broken.
>>>>> (only current user).
>>>> I have just been bisecting the code (from the tip) due to 
>>>> suspend/resume problems and it looks like commit 82fa39b7 is 
>>>> introducing the suspend/resume problem I am seeing (frozen screen).
>>>
>>> It's in tip now.
>>
>> Great, spent some lovely time bisecting and fixing it as well.
>>
> It doesn't work better now than it did before... Trying a 
> suspend/resume while in grub leaves me with a black screen upon resume...

Well, it fixed it for me (autotest migration tests).

Do you mean that 82fa39b7^ works but b784421ce4c doesn't?  What about 
b784421ce4c^ with 82fa39b7 reverted?  That will rule out some other bug.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-03-22 10:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 14:53 [Qemu-devel] [PATCH] Fix migration uint8 arrys handled Juan Quintela
2011-03-18 12:41 ` Yoshiaki Tamura
2011-03-22  0:25 ` Stefan Berger
2011-03-22  1:46   ` Anthony Liguori
2011-03-22  9:28     ` Avi Kivity
2011-03-22 10:23       ` Stefan Berger
2011-03-22 10:40         ` Avi Kivity [this message]
2011-03-22 11:50           ` Supsend/resume regression in c995b4 WAS: " Stefan Berger
2011-03-22 11:56             ` Stefan Berger
2011-03-22 12:00               ` Jan Kiszka
2011-03-22 12:21                 ` Avi Kivity
2011-03-22 12:30                   ` Jan Kiszka
2011-03-22 12:35                     ` Avi Kivity
2011-03-22 12:33                 ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 12:39                   ` Jan Kiszka
2011-03-22 13:26                 ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Anthony Liguori
2011-03-22 13:55                   ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 13:59                     ` Anthony Liguori
2011-03-23  9:10                   ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Avi Kivity
2011-03-23 11:22                     ` Yoshiaki Tamura
2011-03-23 12:15                     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D887CB3.6010505@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).