From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53781 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1z1J-0004XJ-DK for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1z1I-0003nk-AR for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:41:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1z1I-0003nV-0V for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:41:00 -0400 Message-ID: <4D887CB3.6010505@redhat.com> Date: Tue, 22 Mar 2011 12:40:51 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled References: <1300200805-13928-1-git-send-email-quintela@redhat.com> <4D87EC8A.3010309@linux.vnet.ibm.com> <4D87FF80.6060300@us.ibm.com> <4D886BB6.80906@redhat.com> <4D8878BE.5070102@linux.vnet.ibm.com> In-Reply-To: <4D8878BE.5070102@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: Anthony Liguori , qemu-devel@nongnu.org, Juan Quintela On 03/22/2011 12:23 PM, Stefan Berger wrote: > On 03/22/2011 05:28 AM, Avi Kivity wrote: >> On 03/22/2011 03:46 AM, Anthony Liguori wrote: >>> On 03/21/2011 07:25 PM, Stefan Berger wrote: >>>> On 03/15/2011 10:53 AM, Juan Quintela wrote: >>>>> commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c >>>>> >>>>> only contains half of the fix. It forgots the save state fix for >>>>> UINT8 indexes. >>>>> >>>>> Anthony, please apply, without this migration using hpet is broken. >>>>> (only current user). >>>> I have just been bisecting the code (from the tip) due to >>>> suspend/resume problems and it looks like commit 82fa39b7 is >>>> introducing the suspend/resume problem I am seeing (frozen screen). >>> >>> It's in tip now. >> >> Great, spent some lovely time bisecting and fixing it as well. >> > It doesn't work better now than it did before... Trying a > suspend/resume while in grub leaves me with a black screen upon resume... Well, it fixed it for me (autotest migration tests). Do you mean that 82fa39b7^ works but b784421ce4c doesn't? What about b784421ce4c^ with 82fa39b7 reverted? That will rule out some other bug. -- error compiling committee.c: too many arguments to function