From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45093 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q227i-000050-4o for qemu-devel@nongnu.org; Tue, 22 Mar 2011 09:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q227g-0004RV-MN for qemu-devel@nongnu.org; Tue, 22 Mar 2011 09:59:49 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:35950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q227g-0004RP-Fw for qemu-devel@nongnu.org; Tue, 22 Mar 2011 09:59:48 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2MDkiLm003707 for ; Tue, 22 Mar 2011 07:46:44 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2MDxkSk120192 for ; Tue, 22 Mar 2011 07:59:46 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2MDxjpc031474 for ; Tue, 22 Mar 2011 07:59:46 -0600 Message-ID: <4D88AB4C.2080001@us.ibm.com> Date: Tue, 22 Mar 2011 08:59:40 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1300200805-13928-1-git-send-email-quintela@redhat.com> <4D87EC8A.3010309@linux.vnet.ibm.com> <4D87FF80.6060300@us.ibm.com> <4D886BB6.80906@redhat.com> <4D8878BE.5070102@linux.vnet.ibm.com> <4D887CB3.6010505@redhat.com> <4D888CFF.5050204@linux.vnet.ibm.com> <4D888E7F.8040700@linux.vnet.ibm.com> <4D888F6A.1000009@siemens.com> <4D88A372.9040808@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: "qemu-devel@nongnu.org" , Jan Kiszka , Avi Kivity , Stefan Berger On 03/22/2011 08:55 AM, Juan Quintela wrote: > Anthony Liguori wrote: >> On 03/22/2011 07:00 AM, Jan Kiszka wrote: >>> We had a few migration related regressions recently. Do we have >>> sufficient test cases in autotest for them? Also for migrating from >>> older to the latest version? >> Autotest is too late and also not nearly rigorous enough for what >> you're trying to catch. >> >> Here's how I propose we tackle this. This patch adds a -dump-savevm >> option that takes a version. It spits out all of the fields we save >> for a particular version (well, not really, but it should). We also >> can add type information. The idea is that we'd write a simple test >> case (using gtester) that ran through and dumped the schema for each >> version. We'd store the schema's in the tree and the test can compare >> old schema's to the current schema to check for failure. >> >> This was thrown together in just a few minutes. I'll try to put >> together something more complete later today but I wanted to share >> this before the call at least. > This would be an start, althought I still think that a way to dump a > single device, and a way to dump the state of a device in a specific > version is needed. Information as: > - is this always saved > - size of arrays > - .... > > that is there is not saved. Yeah, we can add that down the road though. With just something as simple as this, we can catch quite a few regressions. Regards, Anthony Liguori > Later, Juan.