From: Alexander Graf <agraf@suse.de>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel <qemu-devel@nongnu.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support
Date: Tue, 22 Mar 2011 18:23:04 +0100 [thread overview]
Message-ID: <4D88DAF8.40501@suse.de> (raw)
In-Reply-To: <alpine.DEB.1.10.1103221657370.12173@perard.cam.xci-test.com>
On 03/22/2011 06:22 PM, Anthony PERARD wrote:
> On Tue, 22 Mar 2011, Alexander Graf wrote:
>
>> On 03/22/2011 04:40 PM, Alexander Graf wrote:
>>> make[1]: *** [qemu-system-x86_64] Error 1
>>
>> This should be the correct fix:
>>
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index c0db745..91bbf39 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -212,10 +212,11 @@ endif
>> # xen backend driver support
>> obj-i386-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>>
>> -ifeq ($(TARGET_ARCH), i386)
>> -CONFIG_NO_XEN = $(if $(subst n,,$(CONFIG_XEN)),n,y)
>> +ifeq ($(TARGET_BASE_ARCH),i386)
>> + CONFIG_NO_KVM = $(if $(subst n,,$(CONFIG_KVM)),n,y)
> with 's/KVM/XEN/g'
> ;)
>
>> else
>> -CONFIG_NO_XEN = y
>> + CONFIG_XEN =
>> + CONFIG_NO_XEN = y
>> endif
>> # xen support
>> CONFIG_NO_XEN_MAPCACHE = $(if $(subst n,,$(CONFIG_XEN_MAPCACHE)),n,y)
> Yep, this is the fix.
>
> Could you use this fix and continue to review ? or did I need to resend
> the all patch series ?
No, I'm still at it. It takes much longer than I expected :)
Alex
next prev parent reply other threads:[~2011-03-22 17:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 18:35 [Qemu-devel] [PATCH V11 00/15] Xen device model support anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 01/15] xen: Replace some tab-indents with spaces (clean-up) anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 02/15] xen: Make Xen build once anthony.perard
2011-03-23 10:57 ` Alexander Graf
2011-03-28 14:50 ` [Xen-devel] " Anthony PERARD
2011-03-28 17:29 ` Alexander Graf
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 03/15] xen: Support new libxc calls from xen unstable anthony.perard
2011-03-23 10:43 ` Alexander Graf
2011-03-28 15:22 ` [Xen-devel] " Anthony PERARD
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 04/15] xen: Add initialisation of Xen anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 05/15] xen: Add xenfv machine anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform pci device anthony.perard
2011-03-23 12:08 ` Alexander Graf
2011-03-28 16:08 ` Anthony PERARD
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 07/15] piix_pci: Introduces Xen specific call for irq anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 08/15] xen: Introduce Xen Interrupt Controller anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 09/15] xen: Introduce the Xen mapcache anthony.perard
2011-03-23 12:33 ` Alexander Graf
2011-03-28 16:28 ` [Xen-devel] " Anthony PERARD
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 10/15] configure: Always use 64bits target physical addresses with xen enabled anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 11/15] Introduce qemu_put_ram_ptr anthony.perard
2011-04-06 17:19 ` John Baboval
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 12/15] vl.c: Introduce getter for shutdown_requested and reset_requested anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 13/15] xen: Initialize event channels and io rings anthony.perard
2011-03-23 12:36 ` Alexander Graf
2011-03-28 16:30 ` [Xen-devel] " Anthony PERARD
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 14/15] xen: Set running state in xenstore anthony.perard
2011-03-01 18:35 ` [Qemu-devel] [PATCH V11 15/15] xen: Add Xen hypercall for sleep state in the cmos_s3 callback anthony.perard
2011-03-11 16:29 ` [Qemu-devel] [PATCH V11 00/15] Xen device model support Anthony Liguori
2011-03-11 20:47 ` Alexander Graf
2011-03-22 14:23 ` Alexander Graf
2011-03-22 14:47 ` [Xen-devel] " Anthony PERARD
2011-03-22 15:13 ` Alexander Graf
2011-03-22 15:40 ` Alexander Graf
2011-03-22 15:52 ` Alexander Graf
2011-03-22 17:22 ` Anthony PERARD
2011-03-22 17:23 ` Alexander Graf [this message]
2011-03-23 12:37 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D88DAF8.40501@suse.de \
--to=agraf@suse.de \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).