From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49387 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q25IR-0003vS-7E
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 13:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Q25IQ-0007nz-1H
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 13:23:07 -0400
Received: from cantor2.suse.de ([195.135.220.15]:53803 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Q25IP-0007nk-SL
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 13:23:05 -0400
Message-ID: <4D88DAF8.40501@suse.de>
Date: Tue, 22 Mar 2011 18:23:04 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model
	support
References: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com>
	<4D88B0C6.6040506@suse.de>
	<AANLkTim49k4j5epjeRHnGooB3mQPrMte9D-kXNftC4i1@mail.gmail.com>
	<4D88C2E8.5040509@suse.de> <4D88C5DA.7020909@suse.de>
	<alpine.DEB.1.10.1103221657370.12173@perard.cam.xci-test.com>
In-Reply-To: <alpine.DEB.1.10.1103221657370.12173@perard.cam.xci-test.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

On 03/22/2011 06:22 PM, Anthony PERARD wrote:
> On Tue, 22 Mar 2011, Alexander Graf wrote:
>
>> On 03/22/2011 04:40 PM, Alexander Graf wrote:
>>> make[1]: *** [qemu-system-x86_64] Error 1
>>
>> This should be the correct fix:
>>
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index c0db745..91bbf39 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -212,10 +212,11 @@ endif
>>    # xen backend driver support
>>    obj-i386-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>>
>> -ifeq ($(TARGET_ARCH), i386)
>> -CONFIG_NO_XEN = $(if $(subst n,,$(CONFIG_XEN)),n,y)
>> +ifeq ($(TARGET_BASE_ARCH),i386)
>> +  CONFIG_NO_KVM = $(if $(subst n,,$(CONFIG_KVM)),n,y)
> with 's/KVM/XEN/g'
> ;)
>
>>    else
>> -CONFIG_NO_XEN = y
>> +  CONFIG_XEN =
>> +  CONFIG_NO_XEN = y
>>    endif
>>    # xen support
>>    CONFIG_NO_XEN_MAPCACHE = $(if $(subst n,,$(CONFIG_XEN_MAPCACHE)),n,y)
> Yep, this is the fix.
>
> Could you use this fix and continue to review ? or did I need to resend
> the all patch series ?

No, I'm still at it. It takes much longer than I expected :)


Alex