From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56138 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2K5f-0006cz-Mo for qemu-devel@nongnu.org; Wed, 23 Mar 2011 05:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2K5b-0006da-Ng for qemu-devel@nongnu.org; Wed, 23 Mar 2011 05:10:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2K5b-0006dH-Aj for qemu-devel@nongnu.org; Wed, 23 Mar 2011 05:10:51 -0400 Message-ID: <4D89B915.80406@redhat.com> Date: Wed, 23 Mar 2011 11:10:45 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled References: <1300200805-13928-1-git-send-email-quintela@redhat.com> <4D87EC8A.3010309@linux.vnet.ibm.com> <4D87FF80.6060300@us.ibm.com> <4D886BB6.80906@redhat.com> <4D8878BE.5070102@linux.vnet.ibm.com> <4D887CB3.6010505@redhat.com> <4D888CFF.5050204@linux.vnet.ibm.com> <4D888E7F.8040700@linux.vnet.ibm.com> <4D888F6A.1000009@siemens.com> <4D88A372.9040808@us.ibm.com> In-Reply-To: <4D88A372.9040808@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , Juan Quintela , "qemu-devel@nongnu.org" , Stefan Berger On 03/22/2011 03:26 PM, Anthony Liguori wrote: > > Here's how I propose we tackle this. This patch adds a -dump-savevm > option that takes a version. It spits out all of the fields we save > for a particular version (well, not really, but it should). We also > can add type information. The idea is that we'd write a simple test > case (using gtester) that ran through and dumped the schema for each > version. We'd store the schema's in the tree and the test can compare > old schema's to the current schema to check for failure. > Instead of generating the schema and comparing, what about the other way round? Write vmstate in a formal schema, and generate the code at runtime. -- error compiling committee.c: too many arguments to function