From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44536 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q2PdP-0006Gw-Iu
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:06:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Q2PdN-0008R7-NR
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:06:06 -0400
Received: from goliath.siemens.de ([192.35.17.28]:22986)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Q2PdN-0008Qo-94
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:06:05 -0400
Message-ID: <4D8A0C58.9010809@siemens.com>
Date: Wed, 23 Mar 2011 16:06:00 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 11/11] test-vmstate: add test case to
	verify we don't change VMState
References: <1300839376-22520-1-git-send-email-aliguori@us.ibm.com>	<1300839376-22520-12-git-send-email-aliguori@us.ibm.com>	<AANLkTi=RXFu-_YrxAs7NzNEG=CtqFNs_kLKLWfoXnD9o@mail.gmail.com>	<4D89EABE.50204@codemonkey.ws>	<m3tyetrkf7.fsf@neno.mitica>	<4D8A0947.5080809@codemonkey.ws>
	<AANLkTimCR0Ck67pXiNTFw1CVS08hy7Z_FbjDp48qKSif@mail.gmail.com>
In-Reply-To: <AANLkTimCR0Ck67pXiNTFw1CVS08hy7Z_FbjDp48qKSif@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "quintela@redhat.com" <quintela@redhat.com>

On 2011-03-23 16:00, Peter Maydell wrote:
> On 23 March 2011 14:52, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> I think we ought to merge VMStateDescription into DeviceInfo.  For
>> compatibility, we probably need a vmstate_alias name since the device names
>> don't always map 1-1 with the qdev names.  But this should eliminate the
>> problem of reusing VMStateDescriptions for multiple devices.
> 
> That's a feature, not a bug. Consider eg hw/pl110.c -- there
> are two different DeviceInfo devices but since the underlying
> implementation is the same you definitely don't want to have
> two separate VMStateDescription structures to get out of sync.

Yep. i8254/apic/ioapic vs. (upcoming) i8254-kvm/apic-kvm/ioapic-kvm will
provide further use cases.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux