From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
quintela@redhat.com
Subject: Re: [Qemu-devel] [V2 PATCH] floppy: save and restore DIR register
Date: Mon, 28 Mar 2011 10:16:54 +0200 [thread overview]
Message-ID: <4D9043F6.5070506@redhat.com> (raw)
In-Reply-To: <20110328024726.4753.77783.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com>
On 03/28/11 04:47, Jason Wang wrote:
> We need to keep DIR register unchanged across migration, but currently it
> depends on the media_changed flags from block layer. Since we do not
> save/restore it and the bdrv_open() called in dest node may set the
> media_changed flag when trying to open floppy image, guest driver may think the
> floppy have changed after migration. To fix this, a new filed media_changed in
> FDrive strcutre was introduced in order to save and restore the it from block
> layer through pre_save/post_load callbacks.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/fdc.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 51 insertions(+), 1 deletions(-)
Looks good to me.
Reviewed-by: Jes Sorensen <Jes.Sorensen@redhat.com>
next prev parent reply other threads:[~2011-03-28 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 2:47 [Qemu-devel] [V2 PATCH] floppy: save and restore DIR register Jason Wang
2011-03-28 8:16 ` Jes Sorensen [this message]
2011-03-28 11:18 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9043F6.5070506@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).