From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51988 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4C5D-0002pR-Jm for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4C5C-0005Wn-Es for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:02:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4C5C-0005Wh-2g for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:02:10 -0400 Message-ID: <4D9086CB.7070508@redhat.com> Date: Mon, 28 Mar 2011 15:02:03 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options References: <1301023292-24977-1-git-send-email-david@gibson.dropbear.id.au> <1301023292-24977-28-git-send-email-david@gibson.dropbear.id.au> <4D8CDEFD.9060907@codemonkey.ws> <20110328011922.GH8428@yookeroo> <78393F68-09E8-405D-AAAA-1D42338E032E@suse.de> <4D9083D8.2040503@redhat.com> <67275438-B80C-4C5F-B2A3-D86786DCEEA6@suse.de> In-Reply-To: <67275438-B80C-4C5F-B2A3-D86786DCEEA6@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org, David Gibson On 03/28/2011 02:53 PM, Alexander Graf wrote: > On 28.03.2011, at 14:49, Avi Kivity wrote: > > > On 03/28/2011 11:03 AM, Alexander Graf wrote: > >> I'm also not sure this is too important. Most of our firmware blobs come from svn repos which can't be submoduled. And as long as we don't have a consistent policy about it, we can just as well stick with the README file. > >> > > > > We can have a git mirror of the subversion repository hosted on git.qemu.org, and submodule that. > > *shrug* I'm fairly indifferent on that side. But whatever we do, it's out of scope of this patch set :). I personally don't mind the listing in the README file. It depends on how often the code changes. If it changes regularly and qemu is expected to take in newer versions, then we need to record which slof version comes with which qemu version. Submodules do just that. -- error compiling committee.c: too many arguments to function