From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35782 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4CNG-0003qn-1u for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:20:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4CNE-0000to-J5 for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:20:49 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:52505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4CNE-0000tk-Eq for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:20:48 -0400 Received: by iym10 with SMTP id 10so3722645iym.4 for ; Mon, 28 Mar 2011 06:20:48 -0700 (PDT) Message-ID: <4D908B2D.8040809@codemonkey.ws> Date: Mon, 28 Mar 2011 08:20:45 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 27/27] Add SLOF-based partition firmware for pSeries machine, allowing more boot options References: <1301023292-24977-1-git-send-email-david@gibson.dropbear.id.au> <1301023292-24977-28-git-send-email-david@gibson.dropbear.id.au> <4D8CDEFD.9060907@codemonkey.ws> <20110328011922.GH8428@yookeroo> <78393F68-09E8-405D-AAAA-1D42338E032E@suse.de> <4D9083D8.2040503@redhat.com> <67275438-B80C-4C5F-B2A3-D86786DCEEA6@suse.de> <4D9086CB.7070508@redhat.com> <790CF313-5133-49C9-B95B-B496EA2CAAE1@suse.de> In-Reply-To: <790CF313-5133-49C9-B95B-B496EA2CAAE1@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: David Gibson , paulus@samba.org, Avi Kivity , anton@samba.org, qemu-devel@nongnu.org On 03/28/2011 08:08 AM, Alexander Graf wrote: > >> It depends on how often the code changes. If it changes regularly and qemu is expected to take in newer versions, then we need to record which slof version comes with which qemu version. Submodules do just that. > A commit id / tag in the README document it pretty well, no? Also, a README file is human readable. Submodules don't really buy anyone anything. When I do a release, I do the equivalent of: git submodule update --init rm -rf roms/*/.git rm -rf .git Having the information is submodules makes this process automated and repeatable. The main motivation is that we need to ship source for any binary we include in our tarball. Regards, Anthony Liguori