From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55121 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4CsK-0007Tg-Ud for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4Cs7-0006PO-0n for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:52:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4Cs6-0006PB-GR for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:52:42 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SDqfbn009241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Mar 2011 09:52:41 -0400 Message-ID: <4D909294.4030703@redhat.com> Date: Mon, 28 Mar 2011 15:52:20 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v23 06/11] libcacard: initial commit References: <1300886393-2799-1-git-send-email-alevy@redhat.com> <1300886393-2799-7-git-send-email-alevy@redhat.com> <4D90808B.1090605@redhat.com> <20110328124225.GF28224@playa.redhat.com> In-Reply-To: <20110328124225.GF28224@playa.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/28/11 14:42, Alon Levy wrote: > On Mon, Mar 28, 2011 at 02:35:23PM +0200, Jes Sorensen wrote: >>> +/* >>> + * NSS headers >>> + */ >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include "qemu-common.h" >> >> again here >> >> prthread.h do you have a check for it in configure? I have to admit I >> really would prefer QEMU not relying on the NSPR stuff, but I don't know >> if it can be avoided with the ccid code? > > No, unless you mean I should rewrite the emulation to not use NSS, I don't know > how. Or are you saying NSS can be used without using NSPR? I admited and will > repeat that I have not authored this code (that's why I have Robert Relyea as > the author of this patch), so I'm not familiar with NSS/NSPR except superficially. I don't know enough about NSS to say so, so just leave it in. However, please check that the build doesn't break if one doesn't have the nspr headers installed. >>> diff --git a/libcacard/vreader.c b/libcacard/vreader.c >>> new file mode 100644 >>> index 0000000..0b67c6c >>> --- /dev/null >>> +++ b/libcacard/vreader.c >>> @@ -0,0 +1,519 @@ >>> +/* >>> + * emulate the reader >>> + * >>> + * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. >>> + * See the COPYING.LIB file in the top-level directory. >>> + */ >>> + >>> +/* >>> + * System includes >>> + */ >>> +#include >>> +#include >>> + >>> +#include "qemu-thread.h" >>> +#include "qemu-common.h" >> >> and a last one.... > > Are these a problem enough that you will without an ack? with respect to your > previous acks do you want me to only send this patch again, and Anthony should > merge the acked patches? It would be preferred to have it fixed before the patch goes in, it should be a quick fix. I'll be happy to ack it with that change. Cheers, Jes