From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56127 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4CvA-0008U5-Kr for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4Cv9-0006x3-0Z for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:55:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4Cv8-0006wy-NJ for qemu-devel@nongnu.org; Mon, 28 Mar 2011 09:55:50 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SDtnuN014300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Mar 2011 09:55:50 -0400 Message-ID: <4D909350.6030207@redhat.com> Date: Mon, 28 Mar 2011 15:55:28 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v23 07/11] libcacard: add vscclient References: <1300886393-2799-1-git-send-email-alevy@redhat.com> <1300886393-2799-8-git-send-email-alevy@redhat.com> <4D90827A.8030401@redhat.com> <20110328125159.GG28224@playa.redhat.com> In-Reply-To: <20110328125159.GG28224@playa.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/28/11 14:51, Alon Levy wrote: >> > as mentioned in an earlier series, I think VSCARD_MAGIC needs to be >> > network converted too, to handle difference in endianness between hosts. > Same answer as to your previous comment. > Yeah I saw your answer - I am happy with the code in general, so if you fix the minor nits that is good with me. Cheers, Jes