From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43759 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4DTn-0006PP-Em
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:31:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q4DTl-0005dR-Lk
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:31:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q4DTl-0005dL-6U
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:31:37 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SEVZW2022561
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 10:31:35 -0400
Message-ID: <4D909BB1.7080108@redhat.com>
Date: Mon, 28 Mar 2011 16:31:13 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus
References: <1300886393-2799-1-git-send-email-alevy@redhat.com>
	<1300886393-2799-4-git-send-email-alevy@redhat.com>
	<4D90787D.3090700@redhat.com>
	<20110328142845.GC2741@playa.redhat.com>
In-Reply-To: <20110328142845.GC2741@playa.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/28/11 16:28, Alon Levy wrote:
> On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote:
>> > On 03/23/11 14:19, Alon Levy wrote:
>>> > > A CCID device is a smart card reader. It is a USB device, defined at [1].
>>> > > This patch introduces the usb-ccid device that is a ccid bus. Next patches will
>>> > > introduce two card types to use it, a passthru card and an emulated card.
>>> > > 
>>> > >  [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110.
>>> > > 
>>> > > Signed-off-by: Alon Levy <alevy@redhat.com>
>> > 
>> > This looks ok to me now - I noticed that the comments in the header file
>> > refers to u8/u16/u32 for types, even though the code uses
>> > uint{8,16,32}_t, but I don't think that warrants a fix.
> You mean the comments in hw/usb-ccid.c in the descriptor? that's just shorter.

I wasn't sure if it was a leftover from some of the headers being used
in the kernel. However I am fine with it - no need to change it, and it
makes it shorter as you say.

Cheers,
Jes