From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46419 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4FrR-00078I-Ro
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:04:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q4Fr8-00055F-6d
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:03:59 -0400
Received: from e31.co.us.ibm.com ([32.97.110.149]:55305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q4Fr7-00054p-U8
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:03:54 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2SGmSub013741
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 10:48:28 -0600
Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP
	id p2SH3qJp121914
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 11:03:53 -0600
Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1])
	by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p2SH3qWF001633
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 11:03:52 -0600
Message-ID: <4D90BF77.1090902@us.ibm.com>
Date: Mon, 28 Mar 2011 12:03:51 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RFC][PATCH v1 00/11] QEMU Guest Agent: QMP-based
	host/guest communication (virtagent)
References: <1301082479-4058-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<4D8CFE51.6040905@linux.vnet.ibm.com> <4D8D1131.105@codemonkey.ws>
	<4D8D1902.6030201@linux.vnet.ibm.com>
In-Reply-To: <4D8D1902.6030201@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com

On 03/25/2011 05:36 PM, Michael Roth wrote:
>>> Basically just need a way to pull whatever is stored in the response
>>> qdict's "return" field out without specifying the QTYPE in advance...
>>> which exists in qdict.c:qdict_get_obj(), it's just not currently
>>> exposed to outside callers.
>>
>> Just use qdict_get()--but I still don't understand what the problem is.
>
> Argh! So that solves the "problem" completely. Thanks :)

Yeah, the asymmetry is confusing.  qdict_put() takes anything but a 
QObject yet qdict_get() returns a QObject.  qdict_put_obj() takes a 
QObject and qdict_get_obj() is static.

Regards,

Anthony Liguori

>
>>
>> Regards,
>>
>> Anthony Liguori
>