From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50996 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4GVr-0000xu-SQ
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:46:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q4GVn-0007PF-Ip
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:45:56 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:48507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q4GVn-0007P2-CB
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:45:55 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2SHULwd015463
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 11:30:21 -0600
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p2SHjm0A089564
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 11:45:49 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p2SHjmhw032240
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 11:45:48 -0600
Message-ID: <4D90C94A.7030007@us.ibm.com>
Date: Mon, 28 Mar 2011 12:45:46 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1301082479-4058-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1301082479-4058-9-git-send-email-mdroth@linux.vnet.ibm.com>
	<4D8D091D.6030102@us.ibm.com> <4D8D12FD.6000906@linux.vnet.ibm.com>
In-Reply-To: <4D8D12FD.6000906@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v1 08/12] qemu-char: add qmp_proxy
	chardev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Jes.Sorensen@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org

On 03/25/2011 05:11 PM, Michael Roth wrote:
>> Why are these options required?
>
>
> The qmp_proxy_new() constructor expects a path to a socket it can 
> connect() to. Not sure about telnet, but the other options are 
> required for this. Well...server=on at least, wait=off needs to be set 
> as well because that's the only way to have the socket chardev set the 
> listening socket to non-block, since qmp_proxy_new() calls connect() 
> on it before we return to the main I/O loop.
>
> Although, we probably shouldn't just silently switch out explicitly 
> set options; an error would probably be more appropriate here.

You ought to make qmp_proxy_new() return a CharDriverState such that you 
can do:

qemu -device virtio-serial,chardev=foo -chardev guest-agent,id=foo

Regards,

Anthony Liguori

>>
>> Regards,
>>
>> Anthony Liguori
>>