From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration
Date: Tue, 29 Mar 2011 14:24:55 +0200 [thread overview]
Message-ID: <4D91CF97.3000509@redhat.com> (raw)
In-Reply-To: <m3y63yjg9q.fsf@blackfin.pond.sub.org>
On 03/29/2011 01:52 PM, Markus Armbruster wrote:
>> To avoid this, register the pids in a list and, on SIGCHLD, set up a
>> bottom-half that would go through the pids and reap them.
>
> Signal handler now waitpid()s only for registered children, so it can't
> steal zombies anymore.
Exactly.
>> Since I'm at it, I'm moving iohandler stuff out of vl.c. The new
>> file isn't a perfect place to add the child watcher, but it's arguably
>> better than vl.c.
>
> Pretty much anything's better than vl.c.
>
> You silently drop unused IOHandlerRecord member ufd. Dropping junk
> good, silence not so good.
1/2 had a pretty terse commit message overall.
Paolo
next prev parent reply other threads:[~2011-03-29 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 17:21 [Qemu-devel] [PATCH 0/2] avoid races on exec migration Paolo Bonzini
2011-03-09 17:21 ` [Qemu-devel] [PATCH 1/2] extract I/O handler lists to iohandler.c Paolo Bonzini
2011-04-03 3:18 ` Roy Tam
2011-03-09 17:21 ` [Qemu-devel] [PATCH 2/2] add a service to reap zombies, use it in SLIRP Paolo Bonzini
2011-03-21 8:24 ` [Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration Paolo Bonzini
2011-03-29 9:19 ` Paolo Bonzini
2011-03-29 11:52 ` [Qemu-devel] " Markus Armbruster
2011-03-29 12:24 ` Paolo Bonzini [this message]
2011-03-29 13:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D91CF97.3000509@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).