From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34554 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4Xyn-0003oP-7c for qemu-devel@nongnu.org; Tue, 29 Mar 2011 08:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4Xyl-00034j-Sp for qemu-devel@nongnu.org; Tue, 29 Mar 2011 08:25:01 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:50271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4Xyl-00034W-OQ for qemu-devel@nongnu.org; Tue, 29 Mar 2011 08:24:59 -0400 Received: by wyb42 with SMTP id 42so99528wyb.4 for ; Tue, 29 Mar 2011 05:24:59 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4D91CF97.3000509@redhat.com> Date: Tue, 29 Mar 2011 14:24:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1299691270-16328-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 03/29/2011 01:52 PM, Markus Armbruster wrote: >> To avoid this, register the pids in a list and, on SIGCHLD, set up a >> bottom-half that would go through the pids and reap them. > > Signal handler now waitpid()s only for registered children, so it can't > steal zombies anymore. Exactly. >> Since I'm at it, I'm moving iohandler stuff out of vl.c. The new >> file isn't a perfect place to add the child watcher, but it's arguably >> better than vl.c. > > Pretty much anything's better than vl.c. > > You silently drop unused IOHandlerRecord member ufd. Dropping junk > good, silence not so good. 1/2 had a pretty terse commit message overall. Paolo