From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34104 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4baM-00038M-Q1 for qemu-devel@nongnu.org; Tue, 29 Mar 2011 12:16:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4baK-0005Av-Hb for qemu-devel@nongnu.org; Tue, 29 Mar 2011 12:16:01 -0400 Received: from a.mail.sonic.net ([64.142.16.245]:42085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4baK-0005Ao-5c for qemu-devel@nongnu.org; Tue, 29 Mar 2011 12:16:00 -0400 Message-ID: <4D920545.5050806@twiddle.net> Date: Tue, 29 Mar 2011 09:13:57 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1301405386-25738-1-git-send-email-agraf@suse.de> <1301405386-25738-17-git-send-email-agraf@suse.de> In-Reply-To: <1301405386-25738-17-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 16/19] s390x: Implement opcode helpers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, aurelien@aurel32.net On 03/29/2011 06:29 AM, Alexander Graf wrote: > + if (src == dest) { > + memset((void*)dest, 0, l + 1); > + return 0; > + } This should be g2h(dest), surely. r~