From: Anthony Liguori <anthony@codemonkey.ws>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Don't limit node count by smp count
Date: Wed, 30 Mar 2011 14:28:25 -0500 [thread overview]
Message-ID: <4D938459.4070409@codemonkey.ws> (raw)
In-Reply-To: <1301512475.2976.3.camel@sasha>
On 03/30/2011 02:14 PM, Sasha Levin wrote:
> It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> limited by amount of CPUs.
But does this actually work in the code today and does it work with any
guests?
Regards,
Anthony Liguori
> Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
> ---
> vl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 8bcf2ae..8cc1aa8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3002,8 +3002,8 @@ int main(int argc, char **argv, char **envp)
> if (nb_numa_nodes> 0) {
> int i;
>
> - if (nb_numa_nodes> smp_cpus) {
> - nb_numa_nodes = smp_cpus;
> + if (nb_numa_nodes> MAX_NODES) {
> + nb_numa_nodes = MAX_NODES;
> }
>
> /* If no memory size if given for any node, assume the default
> case
>
>
next prev parent reply other threads:[~2011-03-30 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 19:14 [Qemu-devel] [PATCH] Don't limit node count by smp count Sasha Levin
2011-03-30 19:28 ` Anthony Liguori [this message]
2011-03-30 20:17 ` Sasha Levin
2011-03-30 21:35 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D938459.4070409@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=levinsasha928@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).