From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60663 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5149-0004OM-CP for qemu-devel@nongnu.org; Wed, 30 Mar 2011 15:28:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5143-0002nm-Nf for qemu-devel@nongnu.org; Wed, 30 Mar 2011 15:28:24 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:35804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5143-0002ni-Jy for qemu-devel@nongnu.org; Wed, 30 Mar 2011 15:28:23 -0400 Received: by gyg4 with SMTP id 4so763547gyg.4 for ; Wed, 30 Mar 2011 12:28:22 -0700 (PDT) Message-ID: <4D938459.4070409@codemonkey.ws> Date: Wed, 30 Mar 2011 14:28:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Don't limit node count by smp count References: <1301512475.2976.3.camel@sasha> In-Reply-To: <1301512475.2976.3.camel@sasha> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sasha Levin Cc: qemu-devel@nongnu.org On 03/30/2011 02:14 PM, Sasha Levin wrote: > It is possible to create CPU-less NUMA nodes, node amount shouldn't be > limited by amount of CPUs. But does this actually work in the code today and does it work with any guests? Regards, Anthony Liguori > Signed-off-by: Sasha Levin > --- > vl.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index 8bcf2ae..8cc1aa8 100644 > --- a/vl.c > +++ b/vl.c > @@ -3002,8 +3002,8 @@ int main(int argc, char **argv, char **envp) > if (nb_numa_nodes> 0) { > int i; > > - if (nb_numa_nodes> smp_cpus) { > - nb_numa_nodes = smp_cpus; > + if (nb_numa_nodes> MAX_NODES) { > + nb_numa_nodes = MAX_NODES; > } > > /* If no memory size if given for any node, assume the default > case > >