From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44833 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5GBL-0006Ae-Mu for qemu-devel@nongnu.org; Thu, 31 Mar 2011 07:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5GBK-0006x2-JE for qemu-devel@nongnu.org; Thu, 31 Mar 2011 07:36:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5GBK-0006wp-8i for qemu-devel@nongnu.org; Thu, 31 Mar 2011 07:36:54 -0400 Message-ID: <4D9467CA.9020306@redhat.com> Date: Thu, 31 Mar 2011 13:38:50 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1301487385-1755-1-git-send-email-Jes.Sorensen@redhat.com> <4D9459B8.8000901@redhat.com> <4D946250.5010406@redhat.com> In-Reply-To: <4D946250.5010406@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 31.03.2011 13:15, schrieb Jes Sorensen: > On 03/31/11 12:38, Kevin Wolf wrote: >> Am 30.03.2011 14:16, schrieb Jes.Sorensen@redhat.com: >>> From: Jes Sorensen >>> >>> This adds the basic infrastructure for supporting progress output >>> on the command line, as well as progress support for qemu-img commands >>> 'rebase' and 'convert'. >>> >>> Signed-off-by: Jes Sorensen >> >> Thanks, applied to the block branch. >> >> I think we should consider turning the progress output on by default if >> qemu-img is run from a terminal. > > Thanks! > > I have been a little reluctant to do this because it will break the ABI > for tools running qemu-img from a GUI etc. That's the reason for the "from a terminal" part. If we check for isatty(), we should handle these cases just fine. Kevin