From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54920 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5Mh3-0008P1-0R for qemu-devel@nongnu.org; Thu, 31 Mar 2011 14:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5Mh1-0004Oa-FI for qemu-devel@nongnu.org; Thu, 31 Mar 2011 14:34:04 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:41161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5Mh1-0004OM-CS for qemu-devel@nongnu.org; Thu, 31 Mar 2011 14:34:03 -0400 Received: by iwl42 with SMTP id 42so3151741iwl.4 for ; Thu, 31 Mar 2011 11:34:02 -0700 (PDT) Message-ID: <4D94C916.6080709@codemonkey.ws> Date: Thu, 31 Mar 2011 13:33:58 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers References: <20110331174328.GA25133@redhat.com> In-Reply-To: <20110331174328.GA25133@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 03/31/2011 12:43 PM, Michael S. Tsirkin wrote: > Currently, vga cards that allocate vga ram, > register it as regular ram. When this happens > a lot, vhost need to get notified and flush > its memory tables, which is slow. > > This was observed with cirrus vga. > > As a solution, add an explicit flag when > registering vga ram, vhost-net can simply ignore it. > > Long term, we might be able to use this API > to avoid the need to request > dirty loggin from devices explicitly. > > Tested: with cirrus vga only. > > Signed-off-by: Michael S. Tsirkin Treating vga specially is not the right approach. You want to treat real RAM specially and only make that visible to vhost. See http://wiki.qemu.org/Features/RamAPI There is nothing special about VGA. Regards, Anthony Liguori